Thread (18 messages) 18 messages, 2 authors, 2017-12-16

Re: [PATCH v2 06/10] arm64: dts: qcom: msm8916: move pinconfs to board files

From: Bjorn Andersson <hidden>
Date: 2017-12-16 05:18:40
Also in: linux-arm-kernel, linux-arm-msm, lkml

On Thu 07 Dec 07:19 PST 2017, Damien Riegel wrote:
Following a suggestion from Bjorn Andersson [1], this commit moves
electrical specifications which were defined in mms8916-pins.dtsi to
board files, where they actually belong.

Pinmuxing is kept in the platform file because there are no alternative
pins on which all these functions could be routed, so this part is
indeed common to all boards using this SoC.

[1] https://www.spinics.net/lists/devicetree/msg201764.html

Signed-off-by: Damien Riegel <redacted>
Suggested-by: Bjorn Andersson <redacted>
I like the move, but I would prefer that you mimic the base structure,
rather than just appending properties based on labels.

Regards,
Bjorn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help