Thread (23 messages) 23 messages, 3 authors, 2017-09-25

Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding for DMA controller

From: Stefan Bruens <hidden>
Date: 2017-09-23 23:35:04
Also in: linux-arm-kernel, lkml

On Mittwoch, 20. September 2017 22:53:00 CEST Rob Herring wrote:
On Sun, Sep 17, 2017 at 05:19:52AM +0200, Stefan Brüns wrote:
quoted
The A64 is register compatible with the H3, but has a different number
of dma channels and request ports.

Attach additional properties to the node to allow future reuse of the
compatible for controllers with different number of channels/requests.

If dma-requests is not specified, the register layout defined maximum
of 32 is used.

Signed-off-by: Stefan Brüns <redacted>
---

 .../devicetree/bindings/dma/sun6i-dma.txt          | 26
 ++++++++++++++++++++++ 1 file changed, 26 insertions(+)
diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt
b/Documentation/devicetree/bindings/dma/sun6i-dma.txt index
98fbe1a5c6dd..6ebc79f95202 100644
--- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt
+++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt
@@ -27,6 +27,32 @@ Example:
 		#dma-cells = <1>;
 	
 	};

+-------------------------------------------------------------------------
----- +For A64 DMA controller:
+
+Required properties:
+- compatible:	"allwinner,sun50i-a64-dma"
+- dma-channels: Number of DMA channels supported by the controller.
+		Refer to Documentation/devicetree/bindings/dma/dma.txt
+- all properties above, i.e. reg, interrupts, clocks, resets and
#dma-cells +
+Optional properties:
+- dma-requests: Number of DMA request signals supported by the
controller.
+		Refer to Documentation/devicetree/bindings/dma/dma.txt
+
+Example:
+	dma: dma-controller@01c02000 {
Drop the leading 0. Building dtbs with W=2 will tell you this.

With that,

Acked-by: Rob Herring <redacted>
The leading 0 was copied from the A31 example just a few lines above. Should I 
also correct that one, or should that go in a separate patch?

Kind regards,

Stefan
-- 
Stefan Brüns  /  Bergstraße 21  /  52062 Aachen
home: +49 241 53809034     mobile: +49 151 50412019
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help