Hi Wolfram:

2017-08-12 22:01 GMT+08:00 Wolfram Sang [off-list ref]:

Hi,

quoted

+static const struct rk3x_i2c_soc_data rv1108_soc_data = {
+     .grf_offset = -1,
+     .calc_timings = rk3x_i2c_v1_calc_timings,
+};
+

I don't care super much, but why don't you reuse rk3399_soc_data()?
Or even use the rk3399 compatible as fallback value?

Actually, there is one I2C controller(I2C2) has a different feature with
all the other rockchip soc.The I2C2 is not used on my current board. But I
plan to add this feature later。 So I give RV1108 a new compatible string
here。

Kind regards,

   Wolfram