Thread (22 messages) 22 messages, 5 authors, 2017-08-14

Re: [PATCH v3 02/13] i2c: rk3x: add support for rv1108

From: Wolfram Sang <hidden>
Date: 2017-08-12 14:01:19
Also in: linux-i2c, lkml

Hi,
+static const struct rk3x_i2c_soc_data rv1108_soc_data = {
+	.grf_offset = -1,
+	.calc_timings = rk3x_i2c_v1_calc_timings,
+};
+
I don't care super much, but why don't you reuse rk3399_soc_data()?
Or even use the rk3399 compatible as fallback value?

Kind regards,

   Wolfram

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help