On Tue, 22 Aug 2017, Abhisit Sangjan wrote:

Hi Jonathan - Thank you for your review, I will clean up and submit again.

Please do not top post, only reply in-line.

Also, when replying to a mail, especially one of this length, please
snip past your last comment.  Some people complain that it's a waste
of data (which I don't really subscribe to TBH), but it certainly is a
waste of people's time.  I just spent a good amount of time scrolling
through your reply looking for a response to Jonathan's review, but
none was found.

On Tue, Aug 22, 2017 at 9:03 PM, Jonathan Cameron <
Jonathan.Cameron@huawei.com> wrote:

quoted

On Tue, 22 Aug 2017 13:26:11 +0700
[off-list ref] wrote:

quoted

From: Abhisit Sangjan <redacted>

TI LMP92001 Analog System Monitor and Controller

8-bit GPIOs.
12 DACs with 12-bit resolution.
The GPIOs and DACs are shared port function with Cy function pin to
take control the pin suddenly from external hardware.
DAC's referance voltage selectable for Internal/External.

16 + 1 ADCs with 12-bit resolution.
Built-in internal Temperature Sensor on channel 17.
Windows Comparator Function is supported on channel 1-3 and 9-11 for
monitoring with interrupt signal (pending to implement for interrupt).
ADC's referance voltage selectable for Internal/External.

Signed-off-by: Abhisit Sangjan <redacted>

As Lee said, break this up.  I've done a quick read through but much easier
to parse in smaller parts!

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog