Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible string for I2C EEPROM
From: Masahiro Yamada <hidden>
Date: 2017-06-09 16:12:34
Also in:
linux-arm-kernel, lkml
From: Masahiro Yamada <hidden>
Date: 2017-06-09 16:12:34
Also in:
linux-arm-kernel, lkml
2017-06-07 21:42 GMT+09:00 Javier Martinez Canillas [off-list ref]:
Hello Masahiro, On Wed, Jun 7, 2017 at 3:10 AM, Masahiro Yamada [off-list ref] wrote: [snip]quoted
quoted
quoted
Why didn't you touch arch/arm/boot/dts/uniphier-ref-daughter.dtsi ?Because the compatible string "microchip,24lc128" used by the I2C EEPROM node on that DTS is not supported by the drivers/misc/eeprom/at24.c driver (in fact the only occurrence for 24lc128 I see is in that DTS). Maybe is a typo and it should be "microchip,24c128" instead ?I do not think so. I consulted a board developer. I also see 24LC128 on Microchip web site: http://www.microchip.com/wwwproducts/en/24LC128Ah Ok, it was just a wild guess I did since the at24 driver didn't have support for this chip variant. My point stands though, this is an unrelated change to the goal of this patch-series and should be fixed separately. Best regards, Javier
Applied to linux-uniphier. Thanks! -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html