Thread (32 messages) 32 messages, 6 authors, 2017-06-09

Re: [PATCH v5 05/20] ARM: dts: efm32: Add generic compatible string for I2C EEPROM

From: Javier Martinez Canillas <hidden>
Date: 2017-05-25 20:17:43
Also in: linux-arm-kernel, lkml

Hello Uwe,

On Thu, May 25, 2017 at 8:29 PM, Uwe Kleine-König
[off-list ref] wrote:
Hello,

On Tue, May 23, 2017 at 03:34:33PM +0200, Javier Martinez Canillas wrote:
quoted
The at24 driver allows to register I2C EEPROM chips using different vendor
and devices, but the I2C subsystem does not take the vendor into account
when matching using the I2C table since it only has device entries.

But when matching using an OF table, both the vendor and device has to be
taken into account so the driver defines only a set of compatible strings
using the "atmel" vendor as a generic fallback for compatible I2C devices.

So add this generic fallback to the device node compatible string to make
the device to match the driver using the OF device ID table.

Signed-off-by: Javier Martinez Canillas <redacted>
Assuming the of-table patch is accepted this can have my:

Acked-by: Uwe Kleine-König <redacted>
Thanks a lot for the Ack.
Otherwise I'm not convinced this is worth the churn.
Both changes are needed in order to make sure that the driver and DTS
won't regress when the I2C core is modified to report a proper
MODALIAS for I2C devices registered via OF.
Thanks
Uwe
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help