Thread (15 messages) 15 messages, 3 authors, 2017-06-08

Re: [PATCH v2 4/4] net: macb: Add hardware PTP support

From: Richard Cochran <hidden>
Date: 2017-06-07 13:28:25
Also in: linux-arm-kernel, lkml, netdev

On Wed, Jun 07, 2017 at 11:13:36AM +0000, Rafal Ozieblo wrote:
Please look at following call-stack:

1. macb_interrupt()   // spin_lock(&bp->lock) is taken
2. macb_tx_interrupt()
3. macb_handle_txtstamp()
4. skb_tstamp_tx()
5. __skb_tstamp_tx()
6. skb_may_tx_timestamp()
7. read_lock_bh() // second lock is taken
Well, you can always drop the lock, or postpone the call to
skb_tstamp_tx() until after the spin lock is released...
I know that those are different locks and different types. But this could lead 
to deadlocks. This is the reason of warning I could see.
Can you please post the lockdep splat?

Thanks,
Richard

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help