Re: [PATCH v9 5/5] i2c: aspeed: added slave support for Aspeed I2C driver
From: Brendan Higgins <hidden>
Date: 2017-06-02 18:37:27
Also in:
linux-i2c, lkml, openbmc
From: Brendan Higgins <hidden>
Date: 2017-06-02 18:37:27
Also in:
linux-i2c, lkml, openbmc
On Fri, Jun 2, 2017 at 5:04 AM, Benjamin Herrenschmidt [off-list ref] wrote:
On Fri, 2017-06-02 at 01:46 -0700, Brendan Higgins wrote:quoted
Added slave support for Aspeed I2C controller. Supports fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed.(Not an issue for merging) Have you looked at a "mode" by which you implement just enough of the slave support to decode smbus notifications ? This looks like it could be useful when using pmbus devices, as some of them use smbus notifications fairly often. Today only one driver calls i2c_handle_smbus_host_notify() (the Intel one of course).
Although I have not thought about the exact thing you are mentioning, I want to implement a number of other features for the slave. The thing I am most interested in is adding support for smbus alert from the slave side. Nevertheless, I wanted to actually get the driver in before I start trying to do interesting things. As it is, the slave code satisfies our current purposes and I do not know of anyone else who wants this feature at this time. Cheers