Thread (39 messages) flat view 39 messages, 6 authors, 2017-06-25

Re: [PATCH 4/6] irqchip: irq-mvebu-icu: new driver for Marvell ICU

From: Antoine Tenart <hidden>
Date: 2017-05-30 12:04:06
Also in: linux-arm-kernel, lkml

Hi Thomas,

Very small comment,

On Tue, May 30, 2017 at 11:16:09AM +0200, Thomas Petazzoni wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/irqchip/irq-mvebu-icu.c b/drivers/irqchip/irq-mvebu-icu.c
[...]
+#define ICU_INT_CFG(x)          (0x100 + 4 * x)
You should use (x) here, to be safe.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help