Re: [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU
From: Thomas Petazzoni <hidden>
Date: 2017-05-30 11:41:59
Also in:
linux-arm-kernel, lkml
Hello, Thanks for the quick review! On Tue, 30 May 2017 11:37:10 +0100, Marc Zyngier wrote:
quoted
+ The 1st cell is the group type of the ICU interrupt (SPI_NSR, + SPI_SR, SEI, and REI).Is it worth documenting what these are?
Sure, will do.
quoted
+icu: interrupt-controller@1e0000 { + compatible = "marvell,icu"; + reg = <0x1e0000 0x10>; + #interrupt-cells = <2>;Oh wait...
Gaah, I did spot this mistake, but then forgot to fix it. Will do.
quoted
+ interrupt-controller; + interrupt-parent = <&gic>; + gicp = <&gicp>;Should this be prefixed with a vendor specific identifier, just in case?
Would marvell,gicp be preferable? Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html