On Fri, May 19, 2017 at 03:22:28PM +0800, icenowy-h8G6r0blFSE@public.gmane.org wrote:

在 2017-05-19 15:19，Maxime Ripard 写道：

quoted

On Fri, May 19, 2017 at 11:03:33AM +0800, Icenowy Zheng wrote:

quoted

quoted

The patch looks OK, but given the module is removable, I think it
should be
an overlay. The overlay would enable WiFi + Bluetooth, and all the
peripherals needed to connect them.

That way, if the module is not installed, we avoid confusing the user
with
unused peripherals, and avoid having live voltage on an unoccupied
header.

But as this header have specific usage, we will also confuse user
if it's not enabled as its target usage.

Yet you would enable unused resources.

This was already pointed out here:
https://patchwork.kernel.org/patch/9670235/

I think, before we have an official repository of device tree
overlays (either directly in torvalds/linux or maintained by
linux-sunxi), we shouldn't rely on device tree overlay
functionality.

This is a board specific overlay, and having some upstream repository
with all the possible combinations of SoC / daughter board is just not
realistic.

This should be shipped by the board vendors. RPi does that, the
beaglebone does that, the CHIP does that, surely, if it works for
them, it should work for you.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.