Re: [linux-sunxi] [PATCH v6 9/9] arm64: allwinner: a64: enable Wi-Fi for Pine64

于 2017年5月19日 GMT+08:00 上午11:01:39, Chen-Yu Tsai [off-list ref] 写到:

Hi,

On Thu, May 18, 2017 at 3:16 PM, Icenowy Zheng [off-list ref] wrote:

quoted

The Wi-Fi module of Pine64 is powered via DLDO4 and ELDO1 (the latter
one provides I/O voltage).

Add device node for it.

Although the Wi-Fi module is an external module which should be

inserted

quoted

to a header, according to my personal talk with TL Lim, he does not

want

quoted

this header to be used as GPIO (so it's with 2.0mm pitch, not 2.54mm

as

quoted

other GPIO headers).

The patch looks OK, but given the module is removable, I think it
should be
an overlay. The overlay would enable WiFi + Bluetooth, and all the
peripherals needed to connect them.

That way, if the module is not installed, we avoid confusing the user
with
unused peripherals, and avoid having live voltage on an unoccupied
header.

But as this header have specific usage, we will also confuse user
if it's not enabled as its target usage.

ChenYu

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html