On Thu, May 04, 2017 at 10:07:47PM +0800, Icenowy Zheng wrote:

于 2017年5月4日 GMT+08:00 下午10:04:31, Maxime Ripard [off-list ref] 写到:

quoted

On Thu, May 04, 2017 at 09:49:58PM +0800, Icenowy Zheng wrote:

quoted

Allwinner A10, A20 and R40 SoCs have similar GPIO layout.

Add SoC definitions in pinctrl-sunxi.h, in order to merge A20 support
into A10 driver, and add R40 support into it.

While your commit log is good, the commit title is misleading since
you're not adding it to the A10 driver. You just adding SoC IDs
definitions

Is "pinctrl: sunxi: Add SoC ID definitions for A10, A20 and R40 SoCs" OK?

Yep, it is, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.