Thread (28 messages) 28 messages, 5 authors, 2017-05-22

Re: [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver

From: Icenowy Zheng <hidden>
Date: 2017-05-04 14:03:43
Also in: linux-arm-kernel, linux-clk, linux-gpio, lkml


于 2017年5月4日 GMT+08:00 下午10:02:20, Maxime Ripard [off-list ref] 写到:
On Thu, May 04, 2017 at 09:49:59PM +0800, Icenowy Zheng wrote:
quoted
 static const struct of_device_id sun4i_a10_pinctrl_match[] = {
-	{ .compatible = "allwinner,sun4i-a10-pinctrl", },
+	{
+		.compatible = "allwinner,sun4i-a10-pinctrl",
+		.data = (void *)PINCTRL_SUN4I_A10
+	},
+	{
+		.compatible = "allwinner,sun7i-a20-pinctrl",
+		.data = (void *)PINCTRL_SUN7I_A20
+	},
 	{}
 };
This means you're going to have two drivers probing for the same
device: this driver, and the old one. This is not ok, and probably
introduces some corner cases.
The A20 driver is dropped in the next commit.
Maxime
-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help