Thread (31 messages) 31 messages, 5 authors, 2017-04-13

Re: [RFC 5/8] regulator: anatop: fix min dropout for bypass mode

From: Mark Brown <broonie@kernel.org>
Date: 2017-03-24 12:55:51
Also in: linux-arm-kernel, linux-pm, lkml

On Wed, Mar 22, 2017 at 06:53:07PM +0200, Leonard Crestez wrote:
+	if (anatop_reg->bypass)
+		anatop_reg->rdesc.min_dropout_uV = 0;
+	else
+		anatop_reg->rdesc.min_dropout_uV = LDO_MIN_DROPOUT_UV;
No, this is completely broken - you can't expect to randomly change hthe
regulator description at runtime behind the back of the framework and
expect things to work.  If there is a need to do this we need an
interface for getting the current value and a way to notify of changes.

That said I would not expect the dropout voltage to be considered at
all when the regulator is bypassed, since the regulator is not
regulating it doesn't need any headroom.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help