[RFC 5/8] regulator: anatop: fix min dropout for bypass mode
From: broonie@kernel.org (Mark Brown)
Date: 2017-03-24 12:55:51
Also in:
linux-devicetree, linux-pm, lkml
From: broonie@kernel.org (Mark Brown)
Date: 2017-03-24 12:55:51
Also in:
linux-devicetree, linux-pm, lkml
On Wed, Mar 22, 2017 at 06:53:07PM +0200, Leonard Crestez wrote:
+ if (anatop_reg->bypass) + anatop_reg->rdesc.min_dropout_uV = 0; + else + anatop_reg->rdesc.min_dropout_uV = LDO_MIN_DROPOUT_UV;
No, this is completely broken - you can't expect to randomly change hthe regulator description at runtime behind the back of the framework and expect things to work. If there is a need to do this we need an interface for getting the current value and a way to notify of changes. That said I would not expect the dropout voltage to be considered at all when the regulator is bypassed, since the regulator is not regulating it doesn't need any headroom. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170324/10f882db/attachment-0001.sig>