Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc
From: jacopo <jacopo@jmondi.org>
Date: 2017-03-22 15:36:46
Also in:
linux-gpio, linux-renesas-soc, lkml
From: jacopo <jacopo@jmondi.org>
Date: 2017-03-22 15:36:46
Also in:
linux-gpio, linux-renesas-soc, lkml
Hi Geert,
thanks for reviews
On Wed, Mar 22, 2017 at 02:20:08PM +0100, Geert Uytterhoeven wrote:On Wed, Mar 22, 2017 at 11:33 AM, Geert Uytterhoeven [off-list ref] wrote:quoted
On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi [off-list ref] wrote:quoted
Add device tree bindings documentation for Renesas RZ/A1 gpio and pin--- /dev/null +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rza1-pinctrl.txtulating the pin index from its positionquoted
quoted
+ (port where it sits on and pin offset), and alternate function + configuration options are provided in pin controller header file at:the pin ... filequoted
+ include/dt-bindings/pinctrl/r7s72100-pinctrl.hHence I'd include that file in this patch, as it's part of the bindings.Ah, that would create a hard dependency between the DTS files and the DT bindings, which typically go in through different trees. As the driver replicates the definitions from the header, the include file can go in with the DTS updates.
Sorry, got confused by multiple reviews here.. Are you suggesting to squash [03/07] in [04/07] here? Thanks j
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds