Thread (33 messages) 33 messages, 5 authors, 2017-03-29

Re: [PATCH v2 4/7] arm: dts: r7s72100: Add pin controller node

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2017-03-22 13:12:16
Also in: linux-gpio, linux-renesas-soc, lkml

Hi Jacopo,

On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi [off-list ref] wrote:
Add pin controller node with 12 gpio controller sub-nodes to
r7s72100 dtsi.

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
quoted hunk ↗ jump to hunk
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -183,6 +183,86 @@
                };
        };

+       pinctrl: pinctrl@fcfe3000 {
+               compatible = "renesas,r7s72100-ports";
+
+               #pinctrl-cells = <1>;
+
+               reg = <0xfcfe3000 0x4248>;
How did you get to 0x4248? I had expected 0x4230.
Not that it matters much, Linux rounds it up to a multiple of PAGE_SIZE anyway.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help