Re: [PATCH v2 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64
From: Florian Fainelli <hidden>
Date: 2017-03-14 18:20:40
Also in:
linux-arm-kernel, lkml, netdev
On 03/14/2017 07:18 AM, Corentin Labbe wrote:
quoted hunk ↗ jump to hunk
The dwmac-sun8i hardware is present on the pine64 It uses an external PHY via RMII. Signed-off-by: Corentin Labbe <redacted> --- arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts index c680ed3..b53994d 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts@@ -109,3 +109,18 @@ &usbphy { status = "okay"; }; + +&mdio { + ext_rmii_phy1: ethernet-phy@1 { + reg = <1>;
Even though it's optional, it's nice to have a: compatible = "ethernet-phy-ieee802.3-c22" string here. This applies to all DTS files that you have in subsequent patches. Thanks! -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html