Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue
From: David Miller <hidden>
Date: 2016-11-30 01:14:00
Also in:
linux-amlogic, linux-arm-kernel, lkml, netdev
From: Florian Fainelli <redacted> Date: Tue, 29 Nov 2016 16:43:20 -0800
On 11/29/2016 04:38 PM, David Miller wrote:quoted
From: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> Date: Mon, 28 Nov 2016 10:46:45 +0100quoted
This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F). The platform seems to enter LPI on the Rx path too often while performing relatively high TX transfer. This eventually break the link (both Tx and Rx), and require to bring the interface down and up again to get the Rx path working again. The root cause of this issue is not fully understood yet but disabling EEE advertisement on the PHY prevent this feature to be negotiated. With this change, the link is stable and reliable, with the expected throughput performance. The patchset adds options in the generic phy driver to disable EEE advertisement, through device tree. The way it is done is very similar to the handling of the max-speed property.Patches 1-3 applied to net-next, thanks.Meh, there was a v4 submitted shortly after, and I objected to the whole idea of using that kind of Device Tree properties to disable EEE, we can send reverts though..
Sorry, I lost this in all the discussion, I can revert. Just send me a revert of the entire merge commit a152c91889556df17ca6d8ea134fb2cb4ac9f893 with a short description of why and I'll apply it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html