Re: [PATCH 2/2] dt-bindings: power: add bindings for sbs-charger
From: Sebastian Reichel <sre@kernel.org>
Date: 2016-11-23 13:45:29
Also in:
linux-pm, lkml
Hi, On Wed, Nov 23, 2016 at 12:20:44PM +0100, Nicolas Saenz Julienne wrote:
quoted hunk ↗ jump to hunk
Adds device tree documentation for SBS charger compilant devices as defined here: http://sbs-forum.org/specs/sbc110.pdf Signed-off-by: Nicolas Saenz Julienne <redacted> --- .../bindings/power/supply/sbs_sbs-charger.txt | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/sbs_sbs-charger.txtdiff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-charger.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-charger.txt new file mode 100644 index 0000000..b18ee2a --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-charger.txt@@ -0,0 +1,22 @@ +SBS sbs-charger +~~~~~~~~~~ + +Required properties : + - compatible : "sbs,sbs-charger"
I think the binding should request to add a more specific compatible value and use "sbs,sbs-charger" as fallback. The sbs-charger spec provides a few vendor specific registers. Like this: compatible = "lltc,ltc4100", "sbs,sbs-charger"
+Optional properties :
+- interrupt-parent: Should be the phandle for the interrupt controller. Use in
+ conjunction with "interrupts".
+- interrupts: Interrupt mapping for GPIO IRQ. Use in conjunction with
+ "interrupt-parent". If an interrupt is not provided the driver will switch
+ automatically to polling.
+
+Example:
+
+ ltc4100@9 {
+ compatible = "sbs,sbs-charger";
+ reg = <0x9>;
+ interrupt-parent = <&gpio6>;
+ interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
+ };
+-- Sebastian
Attachments
- signature.asc [application/pgp-signature] 833 bytes