Hi,

On 11/14/2016 09:16 PM, Stephen Boyd wrote:

On 11/07, Stanimir Varbanov wrote:

quoted

+#include <linux/module.h>
+#include <linux/of_reserved_mem.h>
+#include <linux/platform_device.h>
+#include <linux/qcom_scm.h>
+#include <linux/remoteproc.h>
+
+#include "qcom_mdt_loader.h"
+#include "remoteproc_internal.h"
+
+#define VENUS_CRASH_REASON_SMEM		425

This is unused. Is there going to be some common smem API to get
the crash reason?

This is leftover and never used, so I will delete it. About smem maybe
Bjorn have some idea?

quoted

+
+static const struct of_device_id venus_of_match[] = {
+	{ .compatible = "qcom,venus-pil" },
+	{ },
+};

Add a MODULE_DEVICE_TABLE?

OK.

-- 
regards,
Stan