Thread (11 messages) 11 messages, 4 authors, 2016-11-18

Re: [PATCH v2 1/3] firmware: qcom: scm: add a video command for state setting

From: Stanimir Varbanov <hidden>
Date: 2016-11-10 08:05:43
Also in: linux-arm-msm, linux-remoteproc, lkml

Hi,

On 11/10/2016 03:52 AM, Stephen Boyd wrote:
On 11/07, Stanimir Varbanov wrote:
quoted
diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
index d95c70227c05..7e364691a87c 100644
--- a/drivers/firmware/qcom_scm.c
+++ b/drivers/firmware/qcom_scm.c
@@ -320,6 +320,22 @@ bool qcom_scm_is_available(void)
 }
 EXPORT_SYMBOL(qcom_scm_is_available);
 
+int qcom_scm_video_set_state(u32 state, u32 spare)
+{
+	int ret;
+
+	ret = qcom_scm_clk_enable();
Do we need clk control for this? Usually it's only required for
crypto engine things, and turning on video doesn't sound like it
uses crypto. I don't think downstream android kernel does this.
Correct, the crypto clk is not needed.

-- 
regards,
Stan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help