Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads
From: Linus Walleij <hidden>
Date: 2016-11-04 22:24:50
Also in:
linux-gpio, linux-tegra, lkml
On Wed, Nov 2, 2016 at 10:09 AM, Laxman Dewangan [off-list ref] wrote:
NVIDIA Tegra124 and later SoCs support the multi-voltage level and low power state of some of its IO pads. The IO pads can work in the voltage of the 1.8V and 3.3V of IO power rail sources. When IO interface are not used then IO pads can be configure in low power state to reduce the power from that IO pads. On Tegra124, the IO power rail source is auto detected by SoC and hence it is only require to configure in low power mode if IO pads are not used. On T210 onwards, the auto-detection is removed from SoC and hence SW must configure the PMC register explicitly to set proper voltage in IO pads based on IO rail power source voltage. This driver adds the IO pad driver to configure the power state and IO pad voltage based on the usage and power tree via pincontrol framework. The configuration can be static and dynamic. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Looking for an ACK from Stephen &| Thierry.
---
On top of the branch from Thierry's T186 work
https://github.com/thierryreding/linux/tree/tegra186But it's an orthogonal patch right? The build robot seems to have problems with it so pls fix these.
+static const struct pinconf_generic_params tegra_io_pads_cfg_params[] = {
+ {
+ .property = "nvidia,power-source-voltage",
+ .param = TEGRA_IO_PAD_POWER_SOURCE_VOLTAGE,
+ },
+};Why can you not use the standard power-source binding from Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt instead of inventing this nvidia,* variant? Yours, Linus Walleij