Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec
From: Jonathan Cameron <hidden>
Date: 2016-10-30 20:29:18
Also in:
linux-iio, lkml
From: Jonathan Cameron <hidden>
Date: 2016-10-30 20:29:18
Also in:
linux-iio, lkml
On 30 October 2016 20:04:09 GMT+00:00, Brian Masney [off-list ref] wrote:
On Sun, Oct 30, 2016 at 06:37:40PM +0000, Jonathan Cameron wrote:quoted
On 28/10/16 11:00, Brian Masney wrote:quoted
The illuminance0_calibscale sysfs attribute is not currentlycreated byquoted
quoted
the IIO core. This patch adds the appropriate mask toiio_chan_spec,quoted
quoted
along with the appropriate data handling in the read_raw() and write_raw() functions, so that the sysfs attribute is created bythe IIOquoted
quoted
core. With this change, this sysfs entry will have its prefixchangedquoted
quoted
from illuminance0_ to in_illuminance_. Signed-off-by: Brian Masney <redacted>Hmm. Could probably have computed the mean on the fly but fine as is.Hi Jonathan, Thanks for your feedback. I'll have another patch set ready for you by next weekend with my next round of cleanups to that driver. I'll change this so that it calculates the mean on the fly unless I hear otherwise from you.
I don't worry about the mean change. Not worth changing to my mind. J
Brian -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Sent from my Android device with K-9 Mail. Please excuse my brevity.