Re: [PATCH 03/10] staging: iio: tsl2583: return proper error code instead of -1
From: Jonathan Cameron <hidden>
Date: 2016-10-30 17:50:10
Also in:
linux-iio, lkml
On 28/10/16 11:00, Brian Masney wrote:
taos_als_calibrate() has a code path where -1 is returned. This patch changes the code so that a proper error code is returned. Signed-off-by: Brian Masney <redacted>
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. (I'm going to begin to get lazy on this message ;)
quoted hunk ↗ jump to hunk
--- drivers/staging/iio/light/tsl2583.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c index 35c1696..47fd373 100644 --- a/drivers/staging/iio/light/tsl2583.c +++ b/drivers/staging/iio/light/tsl2583.c@@ -373,7 +373,7 @@ static int taos_als_calibrate(struct iio_dev *indio_dev) != (TSL258X_CNTL_ADC_ENBL | TSL258X_CNTL_PWR_ON)) { dev_err(&chip->client->dev, "taos_als_calibrate failed: device not powered on with ADC enabled\n"); - return -1; + return -EINVAL; } ret = i2c_smbus_write_byte(chip->client,