Re: [PATCHv4] hwmon: Add tc654 driver
From: Rob Herring <robh@kernel.org>
Date: 2016-10-10 21:54:47
Also in:
linux-hwmon, linux-i2c, lkml
On Tue, Oct 11, 2016 at 10:26:31AM +1300, Chris Packham wrote:
Add support for the tc654 and tc655 fan controllers from Microchip. http://ww1.microchip.com/downloads/en/DeviceDoc/20001734C.pdf Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- Changes in v4: - tab-align values in #defines - ensure locking in set_pwm covers updating cached values - populate the cached value for the config register in tc654_probe() Changes in v3: - typofix in documentation - add missing value to tc654_pwm_map, re-generate based on datasheet. - remove unnecessary hwmon_dev member from struct tc654_data - bug fixes in set_fan_min() and show_pwm_mode() - miscellaneous style fixes Changes in v2: - Add Documentation/hwmon/tc654 - Incorporate most of the review comments from Guenter. Additional error handling is added. Unused/unnecessary code is removed. I decided not to go down the regmap path yet. I may circle back to it when I look at using regmap in the adm9240 driver. .../devicetree/bindings/i2c/trivial-devices.txt | 2 +
Expect a merge conflict with the IIO tree. Acked-by: Rob Herring <robh@kernel.org>
Documentation/hwmon/tc654 | 31 ++ drivers/hwmon/Kconfig | 11 + drivers/hwmon/Makefile | 1 + drivers/hwmon/tc654.c | 514 +++++++++++++++++++++ 5 files changed, 559 insertions(+) create mode 100644 Documentation/hwmon/tc654 create mode 100644 drivers/hwmon/tc654.c