On 10/11/2016 02:22 AM, Guenter Roeck wrote:

quoted

+	if (val)

quoted

+		data->config |= TC654_REG_CONFIG_DUTYC;
+	else
+		data->config &= ~TC654_REG_CONFIG_DUTYC;

I just realized that this won't work as intended. Problem is that you
only fill data->config when reading an attribute. So, if a set function
is called prior to reading an attribute, data->config will be 0, and
you end up overwriting the original configuration.

Should I just read it in the probe function or fill it in with the 
documented hardware defaults?