Re: [PATCH 2/2] media: adv7604: automatic "default-input" selection
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2016-09-16 09:57:21
Also in:
linux-media, linux-renesas-soc
Hi Ulrich, Thank you for the patch. On Friday 16 Sep 2016 11:39:42 Ulrich Hecht wrote:
Fall back to input 0 if "default-input" property is not present. Documentation states that the "default-input" property should reside directly in the node for adv7612.
Not just fo adv7612.
quoted hunk ↗ jump to hunk
Hence, also adjust the parsing to make the implementation consistent with this. Based on patch by William Towle [off-list ref]. Signed-off-by: Ulrich Hecht <redacted> Signed-off-by: Hans Verkuil <redacted> --- drivers/media/i2c/adv7604.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index 4003831..055c9df 100644 --- a/drivers/media/i2c/adv7604.c +++ b/drivers/media/i2c/adv7604.c@@ -3077,10 +3077,13 @@ static int adv76xx_parse_dt(struct adv76xx_state*state) if (!of_property_read_u32(endpoint, "default-input", &v))
Should this be removed if the property has to be in the device node and not in the endpoint ?
state->pdata.default_input = v; else - state->pdata.default_input = -1; + state->pdata.default_input = 0;
What was the use case for setting it to -1 ? Is it safe to change that ?
of_node_put(endpoint); + if (!of_property_read_u32(np, "default-input", &v)) + state->pdata.default_input = v; + flags = bus_cfg.bus.parallel.flags; if (flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH)
-- Regards, Laurent Pinchart