Re: [PATCH 1/2] media: adv7604: fix bindings inconsistency for default-input
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2016-09-16 09:54:35
Also in:
linux-media, linux-renesas-soc
Hi Ulrich, Thank you for the patch. On Friday 16 Sep 2016 11:39:41 Ulrich Hecht wrote:
The text states that default-input is an endpoint property, but in the example it is a device property. The example makes more sense.
You should explain why it makes more sense. Something along the lines of "The example makes more sense as the default input is a property of the chip, not of a particular port." With that changed, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
quoted hunk ↗ jump to hunk
Signed-off-by: Ulrich Hecht <redacted> --- Documentation/devicetree/bindings/media/i2c/adv7604.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txtb/Documentation/devicetree/bindings/media/i2c/adv7604.txt index 8337f75..9cbd92e 100644--- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt@@ -34,6 +34,7 @@ The digital output port node must contain at least oneendpoint. Optional Properties: - reset-gpios: Reference to the GPIO connected to the device's reset pin. + - default-input: Select which input is selected after reset. Optional Endpoint Properties:@@ -47,8 +48,6 @@ Optional Endpoint Properties: If none of hsync-active, vsync-active and pclk-sample is specified the endpoint will use embedded BT.656 synchronization. - - default-input: Select which input is selected after reset. - Example: hdmi_receiver@4c {
-- Regards, Laurent Pinchart