On 23-09-16, 14:55, Rob Herring wrote:

On Fri, Sep 23, 2016 at 10:45:26AM +0530, Viresh Kumar wrote:

quoted

On 22-09-16, 12:24, Stephen Boyd wrote:

quoted

On 09/21/2016 02:32 AM, Viresh Kumar wrote:

quoted

It was never compulsory to have a compatible string in the OPP table.
Fix the documentation to mark it optional.

NAK.

quoted

quoted

quoted

Also update its description a bit.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---

Why? I'd prefer the compatible string to be required so we know what
sort of node it is.

Agreed.

quoted

Okay, the code doesn't have any checks for it then and that needs to be fixed.

Why? The kernel is not a DT validator.

Hmm.. I thought it should be checking if it can parse those bindings or not.
What if someone adds compatible property as "foo" for OPP node? Should the OPP
code even try to parse it?

quoted

Just for my clarity, for platforms with special OPP bindings and so a different
compatible string like: "operating-points-v2-XYZ", should the compatible string
contain both "operating-points-v2" and the above one? It would be easier to
check for "operating-points-v2" in that case from core code.

That would imply operating-points-v2-XYZ has extra properties or is 
different in some way. If an OS only understanding operating-points-v2 
will work, then yes it should have both. If not, then no.

Well, in this case that can't be done fully, so we should have only the -xyz
one. Got it, thanks.

-- 
viresh