Thread (25 messages) 25 messages, 5 authors, 2016-09-08

Re: [PATCH v3 5/8] pinctrl: Add core support for Aspeed SoCs

From: Linus Walleij <hidden>
Date: 2016-09-07 14:51:50
Also in: linux-gpio, lkml

On Tue, Aug 30, 2016 at 9:54 AM, Andrew Jeffery [off-list ref] wrote:
The Aspeed SoCs typically provide more than 200 pins for GPIO and other
functions. The signal enabled on a pin is determined on a priority
basis, where a given pin can provide a number of different signal types.

In addition to the priority levels, the Aspeed pin controllers describe
the signal active on a pin by compound logical expressions involving
multiple operators, registers and bits. Some difficulty arises as a
pin's function bit masks for each priority level are frequently not the
same (i.e. we cannot just flip a bit to change from a high to low
priority signal), or even in the same register(s). Some configuration
bits affect multiple pins, while in other cases the signals for a bus
must each be enabled individually.

Together, these features give rise to some complexity in the
implementation. A more complete description of the complexities is
provided in the associated header file.

The patch doesn't implement pinctrl/pinmux/pinconf for any particular
Aspeed SoC, rather it adds the framework for defining pinmux
configurations.

Signed-off-by: Andrew Jeffery <redacted>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Patch applied! It's not getting better than this through iteration, it is better
to get the system up and develop inside the mainline tree from now on.
quoted hunk ↗ jump to hunk
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1027,6 +1027,7 @@ S:        Maintained
 F:     arch/arm/mach-aspeed/
 F:     arch/arm/boot/dts/aspeed-*
 F:     drivers/*/*aspeed*
+F:     drivers/pinctrl/aspeed/
 F:     Documentation/devicetree/bindings/*/*aspeed*
I dropped this hunk of the patch, because:

(A) I didn't merge the glob patch and
(B) the glob covers this driver too, it is a tautology/truism

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help