Thread (11 messages) 11 messages, 2 authors, 2016-08-19

Re: [PATCH v6 3/7] power: act8945a_charger: Add status change update support

From: Sebastian Reichel <sre@kernel.org>
Date: 2016-08-19 15:50:40
Also in: linux-arm-kernel, linux-pm, lkml

Hi,

On Fri, Aug 19, 2016 at 09:13:31AM +0800, Wenyou Yang wrote:
 - Fix the 'dev' argument of devm_request_irq() to pdev->dev.parent.
This is not a fix.
+	ret = devm_request_irq(pdev->dev.parent, irq, act8945a_status_changed,
+			       IRQF_TRIGGER_FALLING, "act8945a_interrupt",
+			       charger);
+	if (ret) {
+		dev_err(&pdev->dev, "failed to request nIRQ pin IRQ\n");
+		return ret;
+	}
This will result in the irq not being free'd during device remove,
but when the parent device is removed.

-- Sebastian

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help