Re: [PATCH v6 1/7] power: act8945a_charger: Remove "battery_temperature" | linux-devicetree | Ratatoskr

[PATCH v6 0/7] power: act8945a_charger: Improvements · Wenyou Yang <hidden> · 2016-08-19
[PATCH v6 2/7] power: act8945a_charger: Improve · Wenyou Yang <hidden> · 2016-08-19
[PATCH v6 3/7] power: act8945a_charger: Add status change update support · Wenyou Yang <hidden> · 2016-08-19
Re: [PATCH v6 3/7] power: act8945a_charger: Add status change update support · Sebastian Reichel <sre@kernel.org> · 2016-08-19
[PATCH v6 1/7] power: act8945a_charger: Remove "battery_temperature" · Wenyou Yang <hidden> · 2016-08-19
Re: [PATCH v6 1/7] power: act8945a_charger: Remove "battery_temperature" · Sebastian Reichel <sre@kernel.org> · 2016-08-19
[PATCH v6 5/7] power: act8945a_charger: Add capacity level property · Wenyou Yang <hidden> · 2016-08-19
Re: [PATCH v6 5/7] power: act8945a_charger: Add capacity level property · Sebastian Reichel <sre@kernel.org> · 2016-08-19
[PATCH v6 6/7] power: act8945a_charger: Add max current property · Wenyou Yang <hidden> · 2016-08-19
[PATCH v6 7/7] doc: bindings: act8945a-charger: Update properties · Wenyou Yang <hidden> · 2016-08-19
[PATCH v6 4/7] power: act8945a_charger: Fix the power supply type · Wenyou Yang <hidden> · 2016-08-19

Re: [PATCH v6 1/7] power: act8945a_charger: Remove "battery_temperature"

From: Sebastian Reichel <sre@kernel.org>
Date: 2016-08-19 15:45:04
Also in: linux-arm-kernel, linux-pm, lkml

Hi,

On Fri, Aug 19, 2016 at 09:13:29AM +0800, Wenyou Yang wrote:

-	if (charger->battery_temperature && !(status & APCH_STATUS_TEMPDAT))
+	if (status & APCH_STATUS_TEMPDAT)

This is still wrong. You removed the negation.

-- Sebastian

Attachments

signature.asc [application/pgp-signature] 819 bytes