Re: [PATCH v3 2/2] power: Adds support for Smart Battery System Manager
From: Karl-Heinz Schneider <hidden>
Date: 2016-07-25 19:49:36
Also in:
linux-acpi, linux-i2c, linux-pm
From: Karl-Heinz Schneider <hidden>
Date: 2016-07-25 19:49:36
Also in:
linux-acpi, linux-i2c, linux-pm
Hi Peter, Hi Rob, Am Montag, den 25.07.2016, 12:44 +0200 schrieb Peter Rosin:
On 2016-07-19 20:51, Karl-Heinz Schneider wrote:quoted
quoted
Other than that, looks good to me, yet Peter has more insight to i2c-muxes these days.Tanks for review. Will wait another few days before sending a new revision, hence changes are rather small.Looks good to me from a muxing perspective, with very a minor nit that the devicetree bindings do not point to i2c-mux.txt for where "standard i2c-mux nodes" are described.
Right, will add it. like this:
@@ -7,7 +7,8 @@ Required properties: From OS view the device is basically an i2c-mux used to communicate with up to four smart battery devices at address 0xb. The driver actually implements this behaviour. So standard i2c-mux nodes can be used to register up to four slave -batteries. Channels will be numerated starting from 1 to 4. +batteries. See Documentation/devicetree/bindings/i2c/i2c-mux.txt for more +information on i2c-mux nodes. Channels will be numerated starting from 1 to 4. Example:
Rob, are you OK with that change?
Cheers, Peter
tanks. -- Karl-Heinz