Re: [PATCH v3 6/7] spi: s3c64xx: restore removed comments
From: Michael Turquette <mturquette@baylibre.com>
Date: 2016-07-12 18:07:53
Also in:
linux-arm-kernel, linux-clk, linux-samsung-soc, linux-spi
Possibly related (same subject, not in this thread)
- 2016-07-12 · [PATCH v3 6/7] spi: s3c64xx: restore removed comments · Andi Shyti <hidden>
- 2016-07-12 · Re: [PATCH v3 6/7] spi: s3c64xx: restore removed comments · Mark Brown <broonie@kernel.org>
- 2016-07-12 · Re: [PATCH v3 6/7] spi: s3c64xx: restore removed comments · Andi Shyti <hidden>
- 2016-07-12 · Re: [PATCH v3 6/7] spi: s3c64xx: restore removed comments · Mark Brown <hidden>
Quoting Andi Shyti (2016-07-11 23:54:04)
Patch a9e93e8 has erroneously removed some comments which are important to understand why the bus frequency is multiplied by two during the spi transfer. Reword the previous comment to a more appropriate message. Suggested-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Andi Shyti <redacted> Reviewed-by: Michael Turquette <mturquette@baylibre.com> --- Hi, despite Mike's comments I'm sending the patch as it was originally meant. I think that fixing the exact clk where to set the rate should anyway go in a different patch.
That sounds fair. Regards, Mike
quoted hunk ↗ jump to hunk
V2->V3 The comment has been reworded as Sylwester recommended. Thanks, Andi drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 6da663f..5bedafc 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c@@ -639,6 +639,7 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd) writel(val, regs + S3C64XX_SPI_MODE_CFG); if (sdd->port_conf->clk_from_cmu) { + /* The src_clk clock is divided internally by 2 */ clk_set_rate(sdd->src_clk, sdd->cur_speed * 2); } else { /* Configure Clock */-- 2.8.1