Re: [PATCH v2 6/7] spi: s3c64xx: restore removed comments
From: Michael Turquette <hidden>
Date: 2016-07-08 16:17:28
Also in:
linux-arm-kernel, linux-clk, linux-samsung-soc, linux-spi
Possibly related (same subject, not in this thread)
- 2016-07-12 · Re: [PATCH v2 6/7] spi: s3c64xx: restore removed comments · Sylwester Nawrocki <s.nawrocki@samsung.com>
- 2016-07-11 · Re: [PATCH v2 6/7] spi: s3c64xx: restore removed comments · Michael Turquette <hidden>
- 2016-07-08 · Re: [PATCH v2 6/7] spi: s3c64xx: restore removed comments · Krzysztof Kozlowski <hidden>
- 2016-07-08 · [PATCH v2 6/7] spi: s3c64xx: restore removed comments · Andi Shyti <hidden>
Quoting Andi Shyti (2016-07-08 07:46:40)
quoted hunk
Patch a9e93e8 has erroneously removed some comments which are important to understand why the bus frequency is multiplied by two during the spi transfer. Signed-off-by: Andi Shyti <redacted> --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 6da663f..32b66f0 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c@@ -639,6 +639,7 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd) writel(val, regs + S3C64XX_SPI_MODE_CFG); if (sdd->port_conf->clk_from_cmu) { + /* There is half-multiplier before the SPI */ clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);
Just a small comment, but if the fixed-factor divide-by-two clock was modeled in Linux, then this driver could call clk_set_rate on that clock with the "correct" rate. I guess that this driver would be the provider of that clock? Regards, Mike
} else {
/* Configure Clock */
--
2.8.1-- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html