Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options
From: Rob Herring <hidden>
Date: 2016-06-19 14:30:20
Also in:
linux-rtc, lkml
On Tue, Jun 14, 2016 at 10:59:29PM -0700, Andrey Smirnov wrote:
Add DS1341 specific power-saving options that allow to disable certain functional aspects of the chip in order to minimize its power consumption.
This description doesn't match that you are adding a new binding. It is preferred that bindings are a separate patch.
quoted hunk ↗ jump to hunk
Signed-off-by: Andrey Smirnov <redacted> --- .../devicetree/bindings/rtc/dallas,ds1341.txt | 23 ++++++++++++++++++ drivers/rtc/rtc-ds1307.c | 28 ++++++++++++++++++++++ 2 files changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1341.txtdiff --git a/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt new file mode 100644 index 0000000..b8be7a4 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt@@ -0,0 +1,23 @@ +* Dallas DS1341 I2C Serial Real-Time Clock + +Required properties: + +- compatible: Should contain "dallas,ds1341". + +- reg: I2C address for chip + +Optional properties: + +- disable-oscillator-stop-flag : Configure chip to disable oscillator + fault detection circuitry + +- enable-glitch-filter : Configure chip to enable crystal oscillator + output glitch filtering
What determines setting these properties or not? They should have vendor prefix and be explicit that they are boolean. Rob -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.