Thread (37 messages) 37 messages, 5 authors, 2016-06-07

Re: [PATCH 11/14] regulator: pwm: properly initialize the ->state field

From: Brian Norris <briannorris@chromium.org>
Date: 2016-06-03 20:51:28
Also in: linux-arm-kernel, linux-pwm, linux-rockchip, lkml

On Fri, Jun 03, 2016 at 10:23:09AM +0200, Boris Brezillon wrote:
The ->state field is currently initialized to 0, thus referencing the
voltage selector at index 0, which might not reflect the current voltage
value.
If possible, retrieve the current voltage selector from the PWM state, else
return -EINVAL.

Signed-off-by: Boris Brezillon <redacted>
---
Heiko, Mark,

I know you already added your Tested-by/Acked-by tags on this patch
but this version has slightly change and is now making use of the
pwm_get_relative_duty_cycle() helper instead of manually converting
the absolute duty_cycle value into a relative one.
---
 drivers/regulator/pwm-regulator.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
Tested-by: Brian Norris <briannorris@chromium.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help