Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop
From: Tim Harvey <hidden>
Date: 2016-03-31 18:02:01
Also in:
linux-arm-kernel, linux-watchdog, lkml
On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo [off-list ref] wrote:
On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote:quoted
The question was if the property name should be ext-reset-output or fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output because it is not a generic property. Tim disagrees.
Guenter, My issue regarding the vendor prefix was not a hard dissagreement but was more about me understanding the rational behind using vendor prefixes. In this case the imx2_wdt driver 'is' a vendor specific driver as its compatible strings are prefixed with 'fsl,' so isn't 'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt inherently a vendor specific properly already? I assume that is why the 'big-endian' property isn't 'fsl,big-endian'. Maybe it's more about if it 'is' marked as a vendor specific property its much easier to get approval and accepted by a vendor-specific maintainer?
quoted
So we have two options: Change the property name to fsl,ext-reset-output, which I would accept, or wait for a devicetree maintainer to make a decision.Guenter, I agree with you on this point. Before everyone agrees that this is a generic binding, we should have vendor prefix for the property. Tim, This is a small change which, IMO, shouldn't hold an useful patch from being merged. Care to resend with the suggested change? Shawn
Shawn, Sure - I'll rebase and re-submit. Tim -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html