On 29/03/16 15:44, Bjorn Andersson wrote:

On Wed 23 Mar 12:48 PDT 2016, Srinivas Kandagatla wrote:

quoted

This patch adds nodes required to enable 4 i2c buses on the board which
are connected to various sensors and eeprom.

I would like for the pinconf for these blocks to be in this patch (and
file) to make it clear how they are configured and where to change them.

When I started adding this I had same opinion, I will do that in next 
release.

thanks,
srini

Regards,
Bjorn

quoted

Signed-off-by: Srinivas Kandagatla <redacted>
---
  .../arm/boot/dts/qcom-apq8064-dragonboard-600c.dts | 46 ++++++++++++++++++++++
  1 file changed, 46 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts b/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts
index 4fecd94..942de04 100644
--- a/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts
+++ b/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts

@@ -8,6 +8,10 @@
  	aliases {
  		serial0 = &gsbi7_serial;
  		serial1 = &gsbi1_serial;
+		i2c0 = &gsbi2_i2c;
+		i2c1 = &gsbi3_i2c;
+		i2c2 = &gsbi4_i2c;
+		i2c3 = &gsbi7_i2c;
  	};

  	regulators {

@@ -180,6 +184,42 @@
  			};
  		};

+		gsbi@12480000 {
+			status = "okay";
+			qcom,mode = <GSBI_PROT_I2C>;
+			i2c@124a0000 {
+				/* On Low speed expansion and Sensors */
+				label = "LS-I2C0";
+				status = "okay";
+			};
+		};
+
+		gsbi@16200000 {
+			status = "okay";
+			qcom,mode = <GSBI_PROT_I2C>;
+			i2c@16280000 {
+			/* On Low speed expansion */
+				status = "okay";
+				label = "LS-I2C1";
+				clock-frequency = <200000>;
+				eeprom@52 {
+					compatible = "atmel,24c128";
+					reg = <0x52>;
+					pagesize = <64>;
+				};
+			};
+		};
+
+		gsbi@16300000 {
+			status = "okay";
+			qcom,mode = <GSBI_PROT_I2C>;
+			i2c@16380000 {
+				/* On High speed expansion */
+				label = "HS-CAM-I2C3";
+				status = "okay";
+			};
+		};
+
  		/* DEBUG UART  */
  		gsbi@16600000 {
  			status = "okay";

@@ -190,6 +230,12 @@
  				pinctrl-names = "default";
  				pinctrl-0 = <&gsbi7_uart_2pins>;
  			};
+
+			i2c@16680000 {
+				/* On High speed expansion */
+				status = "okay";
+				label = "HS-CAM-I2C2";
+			};
  		};

  		leds {
--

2.5.0