Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS
From: Rob Herring <robh@kernel.org>
Date: 2016-03-02 18:26:42
Also in:
linux-arm-kernel, linux-clk, linux-omap, linux-pwm, lkml
On Thu, Feb 25, 2016 at 04:36:36PM -0600, Franklin S Cooper Jr wrote:
quoted hunk ↗ jump to hunk
From: Vignesh R <vigneshr@ti.com> Add PWMSS device tree nodes for DRA7 SoC family and add documentation for dt bindings. Signed-off-by: Vignesh R <vigneshr@ti.com> --- Version 3 changes: None .../devicetree/bindings/pwm/pwm-tiehrpwm.txt | 8 +++ .../devicetree/bindings/pwm/pwm-tipwmss.txt | 17 +++++- arch/arm/boot/dts/dra7.dtsi | 64 ++++++++++++++++++++++ 3 files changed, 88 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt index 9c100b2..25d91ae 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt +++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt@@ -4,6 +4,7 @@ Required properties: - compatible: Must be "ti,<soc>-ehrpwm". for am33xx - compatible = "ti,am33xx-ehrpwm"; for da850 - compatible = "ti,da850-ehrpwm", "ti,am33xx-ehrpwm"; + for dra7xx - compatible = "ti,dra7xx-ehrpwm", "ti,am33xx-ehrpwm";
We're starting to push back on wildcards in compatible strings. I guess this is okay...
quoted hunk ↗ jump to hunk
- #pwm-cells: should be 3. See pwm.txt in this directory for a description of the cells format. The only third cell flag supported by this binding is PWM_POLARITY_INVERTED.@@ -27,3 +28,10 @@ ehrpwm0: ehrpwm@0 { /* EHRPWM on da850 */ #pwm-cells = <3>; reg = <0x300000 0x2000>; }; + +ehrpwm0: ehrpwm@0 { /* EHRPWM on dra7xx */
Should be pwm@48440200
+ compatible = "ti,dra7xx-ehrpwm", "ti,am33xx-ehrpwm"; + #pwm-cells = <3>; + reg = <0x48440200 0x80>; + ti,hwmods = "ehrpwm0"; +};