Re: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support

On Fri, Feb 19, 2016 at 10:10:04AM +0000, Zhiqiang Hou wrote:

<snip>

quoted

quoted

+	pca9547@77 {
+		compatible = "philips,pca9547";

I cannot find this compatible string in either binding docs or driver code.

See the file below.
./drivers/i2c/muxes/i2c-mux-pca954x.c:115:	{ "pca9547", pca_9547 },
Perhaps the vender name should be updated to nxp.

Yes, if you look at Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt,
"nxp,pca9547" is the one you should use here.

<snip>

quoted

quoted

+			eeprom@56 {
+				compatible = "at24,24c512";

Unsupported/undocumented compatible?

Will change it to "atmel, 24c512".

Yes, but without the space in the middle.

quoted

quoted

+				reg = <0x56>;
+			};
+
+			eeprom@57 {
+				compatible = "at24,24c512";
+				reg = <0x57>;
+			};
+
+			adt7461a@4c {

temp-sensor should be a better node name, if I understand the device correctly.

I didn't find a reference in kernel, so what name should be better, do you have any advice?

"temp-sensor" is what I see from the example in
Documentation/devicetree/bindings/hwmon/lm90.txt.

Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html