On Fri, Feb 19, 2016 at 10:10:04AM +0000, Zhiqiang Hou wrote:
<snip>
quoted
quoted
+ pca9547 at 77 {
+ compatible = "philips,pca9547";
I cannot find this compatible string in either binding docs or driver code.
See the file below.
./drivers/i2c/muxes/i2c-mux-pca954x.c:115: { "pca9547", pca_9547 },
Perhaps the vender name should be updated to nxp.
Yes, if you look at Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt,
"nxp,pca9547" is the one you should use here.
<snip>
quoted
quoted
+ eeprom at 56 {
+ compatible = "at24,24c512";
Unsupported/undocumented compatible?
Will change it to "atmel, 24c512".
Yes, but without the space in the middle.
quoted
quoted
+ reg = <0x56>;
+ };
+
+ eeprom at 57 {
+ compatible = "at24,24c512";
+ reg = <0x57>;
+ };
+
+ adt7461a at 4c {
temp-sensor should be a better node name, if I understand the device correctly.
I didn't find a reference in kernel, so what name should be better, do you have any advice?
"temp-sensor" is what I see from the example in
Documentation/devicetree/bindings/hwmon/lm90.txt.
Shawn
Hi Shawn,
Thanks for your advice!
-----Original Message-----
From: Shawn Guo [mailto:shawnguo at kernel.org]
Sent: 2016?2?28? 10:38
To: Zhiqiang Hou <zhiqiang.hou@nxp.com>
Cc: Zhiqiang Hou <redacted>; mark.rutland at arm.com;
devicetree at vger.kernel.org; Shaohui.Xie at freescale.com; pawel.moll at arm.com;
ijc+devicetree at hellion.org.uk; catalin.marinas at arm.com; will.deacon at arm.com;
robh+dt at kernel.org; galak at codeaurora.org; scottwood at freescale.com;
Mingkai.Hu at freescale.com; linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support
On Fri, Feb 19, 2016 at 10:10:04AM +0000, Zhiqiang Hou wrote:
<snip>
quoted
quoted
quoted
+ pca9547 at 77 {
+ compatible = "philips,pca9547";
I cannot find this compatible string in either binding docs or driver code.
See the file below.
./drivers/i2c/muxes/i2c-mux-pca954x.c:115: { "pca9547", pca_9547 },
Perhaps the vender name should be updated to nxp.
Yes, if you look at Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt,
"nxp,pca9547" is the one you should use here.
<snip>
quoted
quoted
quoted
+ eeprom at 56 {
+ compatible = "at24,24c512";
Unsupported/undocumented compatible?
Will change it to "atmel, 24c512".
Yes, but without the space in the middle.
quoted
quoted
quoted
+ reg = <0x56>;
+ };
+
+ eeprom at 57 {
+ compatible = "at24,24c512";
+ reg = <0x57>;
+ };
+
+ adt7461a at 4c {
temp-sensor should be a better node name, if I understand the device correctly.
I didn't find a reference in kernel, so what name should be better, do you have
any advice?
"temp-sensor" is what I see from the example in
Documentation/devicetree/bindings/hwmon/lm90.txt.
Thanks,
Zhiqiang