Thread (9 messages) 9 messages, 6 authors, 2016-02-26

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

From: Li Yang <hidden>
Date: 2016-02-26 18:04:59
Also in: linux-pm, linuxppc-dev

Possibly related (same subject, not in this thread)

On Fri, Dec 18, 2015 at 4:32 PM, Arnd Bergmann [off-list ref] wrote:
On Tuesday 15 December 2015 00:58:26 Rafael J. Wysocki wrote:
quoted
On Thursday, November 26, 2015 05:21:11 PM Jia Hongtao wrote:
quoted
Register the qoriq cpufreq driver as a cooling device, based on the
thermal device tree framework. When temperature crosses the passive trip
point cpufreq is used to throttle CPUs.

Signed-off-by: Jia Hongtao <redacted>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied, thanks!
I got a randconfig build error today:

drivers/built-in.o: In function `qoriq_cpufreq_ready':
debugfs.c:(.text+0x1f4688): undefined reference to `of_cpufreq_cooling_register'

CONFIG_OF=y
CONFIG_QORIQ_CPUFREQ=y
CONFIG_THERMAL=m
CONFIG_THERMAL_OF=y

I think you need a 'depends on THERMAL' to prevent the driver from
being built-in when THERMAL=m.
Maybe this is not the best approach.  The cpufreq feature itself
should be working independently without thermal framework.  I think we
should make the qoriq_cpufreq_ready() defined as null function if
THERMAL is not defined.

Regards,
Leo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help