On 01/11/2016 08:54 AM, Hongtao Jia wrote:

Sorry for the late response. I got a knee surgery to do.
See comments at the end.

quoted

-----邮件原件-----
发件人: Arnd Bergmann [mailto:arnd@arndb.de]
发送时间: Saturday, December 19, 2015 6:33 AM
收件人: Rafael J. Wysocki [off-list ref]
抄送: Jia Hongtao [off-list ref]; edubezval@gmail.com;
viresh.kumar@linaro.org; linux-pm@vger.kernel.org; linuxppc-
dev@lists.ozlabs.org; devicetree@vger.kernel.org; Scott Wood
[off-list ref]
主题: Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device
tree

On Tuesday 15 December 2015 00:58:26 Rafael J. Wysocki wrote:

quoted

On Thursday, November 26, 2015 05:21:11 PM Jia Hongtao wrote:

quoted

Register the qoriq cpufreq driver as a cooling device, based on the
thermal device tree framework. When temperature crosses the passive
trip point cpufreq is used to throttle CPUs.

Signed-off-by: Jia Hongtao <redacted>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

Applied, thanks!

I got a randconfig build error today:

drivers/built-in.o: In function `qoriq_cpufreq_ready':
debugfs.c:(.text+0x1f4688): undefined reference to
`of_cpufreq_cooling_register'

CONFIG_OF=y
CONFIG_QORIQ_CPUFREQ=y
CONFIG_THERMAL=m
CONFIG_THERMAL_OF=y

I think you need a 'depends on THERMAL' to prevent the driver from being
built-in when THERMAL=m.

Arnd

Correct. I need to add following lines to the Kconfig file:
depends on !CPU_THERMAL || THERMAL=y

Hi Rafael,
Should I send a new patch include this fix or send a fix patch?

Why THERMAL=y and not just THERMAL, which would allow building this
driver as a module?

-Scott

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev