Re: [PATCH 1/4] arm64: Broadcom Vulcan support

On Wed, Feb 17, 2016 at 10:46 PM, Mark Rutland [off-list ref] wrote:

Hi,

On Sun, Feb 14, 2016 at 12:16:32AM +0530, Jayachandran C wrote:

quoted

From: Zi Shen Lim <zlim-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

quoted

+     compatible = "brcm,vulcan-eval", "brcm,vulcan";

You use "brcm,vulcan" as the compatible string for both the platform and
the CPU nodes. You need different strings.

quoted

+
+     memory {
+             device_type = "memory";
+             reg = <0x00000000 0x80000000 0x0 0x80000000>,  /* 2G @ 2G  */
+                   <0x00000008 0x80000000 0x0 0x80000000>;  /* 2G @ 34G */
+     };

quoted

+/memreserve/ 0x80000000 0x00010000;

What is this for?

This seems to left over from the time we were using spin. Will take
it out. Thanks.

quoted

+
+/ {
+     model = "Broadcom Vulcan";
+     compatible = "brcm,vulcan";

As above, it doesn't make sense to have the same compatible string for
both the platform as a whole and the CPU.

Will fix this in v2.

quoted

+                     device_type = "cpu";
+                     compatible = "brcm,vulcan", "arm,armv8";
+                     reg = <0x0 0x0>;
+                     enable-method = "psci";
+             };

Thanks for the review.

JC.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html