Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.
From: Scott Wood <oss@buserror.net>
Date: 2016-02-25 03:11:57
Also in:
linuxppc-dev, lkml
On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote:
On Wed, 2016-02-24 at 04:20 AM, Scott Wood wrote:quoted
-----Original Message----- From: Scott Wood [mailto:oss@buserror.net] Sent: Wednesday, February 24, 2016 4:20 AM To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com> Cc: Yang-Leo Li <redacted>; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings. On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:quoted
On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:quoted
Add IC, SI and SIRAM document of QE to Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> --- Changes for v2 - Add interrupt-controller in Required properties - delete address-cells and size-cells for qe-si and qe-siram .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 ++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt index 4f89302..84052a7 100644--- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt@@ -69,6 +69,56 @@ Example: }; }; +* Interrupt Controller (IC) + +Required properties: +- compatible : should be "fsl,qe-ic".quoted
+- compatible : should be "fsl,qe-si".quoted
+- compatible : should be "fsl,qe-siram".These compatible strings are all a bit generic and should have SoC specific compatible strings.I don't know about si/siram, but "fsl,qe-ic" has been around since 2008, so it should be documented even if a more specific compatible is also added.Agree, and si/siram are also has been around since 2008.
Where? I couldn't find them when grepping.
In addition, I don’t think it is needed to add specific compatible, because they are the same in qe-supported soc.
How do we know that they are 100% the same? -Scott