Re: [PATCH RFC 2/3] DT: add binding for SN3218 LED driver
From: Rob Herring <robh@kernel.org>
Date: 2016-01-29 03:26:43
Also in:
linux-leds, lkml
On Thu, Jan 28, 2016 at 08:41:06PM +0000, Stefan Wahren wrote:
This patch adds the binding for Si-En Technology SN3218 18-Channel LED driver. Signed-off-by: Stefan Wahren <redacted> --- .../devicetree/bindings/leds/leds-sn3218.txt | 41 ++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-sn3218.txt
One nit, otherwise: Acked-by: Rob Herring <robh@kernel.org>
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/leds/leds-sn3218.txt b/Documentation/devicetree/bindings/leds/leds-sn3218.txt new file mode 100644 index 0000000..bf632df --- /dev/null +++ b/Documentation/devicetree/bindings/leds/leds-sn3218.txt@@ -0,0 +1,41 @@ +* Si-En Technology - SN3218 18-Channel LED Driver + +Required properties: +- compatible : + "si-en,sn3218" +- address-cells : must be 1 +- size-cells : must be 0 +- reg : I2C slave address, typically 0x54 + +Each led is represented as a sub-node of the si-en,sn3218 device. + +LED sub-node properties: +- label : (optional) see Documentation/devicetree/bindings/leds/common.txt +- reg : number of LED line (could be from 0 to 17) +- linux,default-trigger : (optional) + see Documentation/devicetree/bindings/leds/common.txt + +Example: + +sn3218@54 { + compatible = "si-en,sn3218"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x54>; + + led1@0 {
Just led@X please.
+ label = "led1";
+ reg = <0x0>;
+ };
+
+ led2@1 {
+ label = "led2";
+ reg = <0x1>;
+ };
+
+ led3@2 {
+ label = "led3";
+ reg = <0x2>;
+ };
+};
+
--
1.7.9.5